refactor: Use ConstVec for instructions in Executable
#5096
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
DCNick3
previously approved these changes
Sep 23, 2024
mversic
reviewed
Sep 23, 2024
mversic
requested changes
Sep 23, 2024
mversic
approved these changes
Sep 24, 2024
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
dima74
force-pushed
the
diralik/executable-box-instructions
branch
from
a2708bf
to
7240b99
Compare
DCNick3
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Meta: #5083
Fixes #5092
Solution
Use
Box<[InstructionBox]>instead ofVecto ensure we don't waste any memory on a buffer.See #5083 (comment), #5083 (comment), and #5083 (comment) for details
Checklist
CONTRIBUTING.md.